From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 07 Jul 2020 22:37:42 GMT
Subject: Re: [PATCH] Make some commit hashes in tests reproducible
Message-ID: <xmqqk0zf2bpl.fsf@gitster.c.googlers.com>
In-Reply-To: <20200707215206.GA2300296@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I'm also skeptical how often we use system times anyway, because _any_
> use of test_commit or test_tick in a script is enough to make all of the
> subsequent commands deterministic. I'd be more inclined to let a
> particular script say "I'm interested in random times". But then, I'd
> think such a script would be better written to trigger its interesting
> cases with a well-crafted set of deterministic times.

Yeah, the DEVELOPER=YesPlease was a tongue-in-cheek comment.  

Reproducibility would mean we see less test breakages due to
raciness, but I do not recall a case where digging into test
breakage due to raciness led to discovery of and fix to a real
breakage in Git itself, so it is probably a good thing.

Thanks.