Re: [RFC PATCH 0/1] adding user.hideTimezone for setting UTC timezone

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 8, 2020, 19:49 UTC
Message-ID: <xmqqk0w0wl9t.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqqh7rec5h3.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 20 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> In addition to not having to futz with TZ, I think I like the
>> semantics better.  The motivation that started this thread was not so
>> much "I want to set a custom timezone to blend in" but rather "why are
>> we recording the timezone at all here?"  In that context, it makes
>> sense to me to have a setting such as
>>
>> 	core.recordTimeZone
>>
>> that I can turn *off* to say that I don't think datestamp() callers
>> should consider the timezone to be information worth recording (and
>> instead they should write +0000).  To me that seems a little simpler
>> to understand than user.hideTimezone since this focuses on turning
>> some functionality off (recording of the time zone) instead of turning
>> on a new stealth mode.
>
> Hmph.  It is a valid way to look at the issue, I guess.
>
> Thanks for an input.

I do not have a strong opinion on recordTimeZone vs hideTimeZone any more (the latter, as proposed by Shengfa, is shorter to type ;-), but I think it is a good idea to keep it in user.* hierarchy. It sits next to user.name and user.email and controls how the user ident is formulated.