Re: [RFC PATCH 1/1] hideTimezone: add a user.hideTimezone config
- From
- Shengfa Lin <shengfa@google.com>
- Date
- Oct 2, 2020, 06:51 UTC
- Message-ID
- <20201002065135.4096175-1-shengfa@google.com>
- In-Reply-To
- <xmqqh7rees6h.fsf@gitster.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 7 quoted lines
>> Users requested hiding location in the world from source control >> trail. This is an implementation to read user.hideTimezone in >> cmd_commit and set timezone to UTC if it's true. > > Not a very good proposed log message, that sounds as if "it is > what 'Users' requested, so it must be a worthwhile thing to do", > which is not the line of thinking to go by.
That's a good point. Users requested does not necessarily equivalent to worthwhile thing to do. Thanks for pointing it out.