git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: switch peel_ref() to peel_iterated_oid()

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 22, 2021, 21:38 UTC
Message-ID
<xmqqk0s47iuo.fsf@gitster.c.googlers.com>
In-Reply-To
<YAiOPzOT52v+dOgL@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 23 quoted lines
> On Wed, Jan 20, 2021 at 02:44:43PM -0500, Jeff King wrote:
>> This has been bugging me for years, and came up again in:
>>
>>   https://lore.kernel.org/git/YAhXw9Gvn5Pyvacq@coredump.intra.peff.net/
>>
>> so I decided to finally do something about it. There's a minor textual
>> conflict with the caller being touched in that thread, but it's easy to
>> resolve. So I think it's OK to consider the two independent.
>>
>> The commit message turned out rather long. I hope that doesn't scare
>> anybody away, but I wanted to cover all of the bases.
>
> Thanks for all of the detail. Suffice it to say, I was not scared away,
> and am in fact quite comfortable with this direction.
>
> Sorry for sending such a short response to such a long email, but I
> agree with the discussion in the patch message, and I don't have
> anything to add other than my approval and a:
>
>   Reviewed-by: Taylor Blau <me@ttaylorr.com>
>
> Thanks,
> Taylor
Thanks, both.
Previous: Taylor Blau
Message 3 of 3 in “refs: switch peel_ref() to peel_iterated_oid()”
  1. refs: switch peel_ref() to peel_iterated_oid()Jeff King, Jan 20, 2021
  2. Taylor BlauJan 20, 2021
  3. Junio C HamanoJan 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.