Re: [PATCH v2] receive-pack: purge temporary data if no command is ready to run

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2022, 23:27 UTC
Message-ID: <xmqqk0ee9nhe.fsf@gitster.g>
In-Reply-To: <xmqqczk6b3pt.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 9 quoted lines

>> index 9f4a0b816c..a0b193ab3f 100644
>> --- a/builtin/receive-pack.c
>> +++ b/builtin/receive-pack.c
>> @@ -1971,6 +1971,15 @@ static void execute_commands(struct command *commands,
>>  		return;
>>  	}
>
> With the new logic, "return;" we see above becomes unnecessary.  I
> wonder if it is a good idea to keep it or remove it.

I think it makes the code easier to maintain to keep the above "return;". There may be some code added in the future right here, before the final "if no ref updates succeeds, leave early" this patch adds, and it is unlikely we would want to run it when pre-receive rejects the push.

IOW, this part of the patch that did not touch the above "return;" is just fine as-is.

Thanks.