Re: [PATCH] tab completion of filenames for 'git restore'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 15, 2022, 10:23 UTC
- Message-ID
- <xmqqk0cvh5u0.fsf@gitster.g>
- In-Reply-To
- <2ae04989-156c-63a2-c191-67f97bb6c7b9@cantrell.org.uk>
David Cantrell <david@cantrell.org.uk> writes:
Show 20 quoted lines
>>> @@ -2883,14 +2883,21 @@ _git_restore ()
>>> case "$cur" in
>>> --conflict=*)
>>> __gitcomp "diff3 merge zdiff3" "" "${cur##--conflict=}"
>>> + return
>>> ;;
>>> --source=*)
>>> __git_complete_refs --cur="${cur##--source=}"
>>> + return
>>> ;;
>>> ...
>> Do you need to sprinkle return's? Instead you could just add
>> another case arm, like
>> + *)
>> + ... whatever you want to do when
>> + ... $cur is not a --dashed-option
>> + ;;
>
> Liberal sprinkling of return like that seems to be the norm for the
> rest of the file so I stuck with it.An existing bad practice is not a good excuse to spread it even more, though.