Re: [PATCH v3] tracking branches: add advice to ambiguous refspec error

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 28, 2022, 20:32 UTC
Message-ID: <xmqqk0cd24yn.fsf@gitster.g>
In-Reply-To: <220328.86y20t3o5s.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> But as to not penalizing those who don't have the advice enabled,
> something like this (untested)?:

Unconditionally computing what you need only in the error path is the primary sin in the patch, and that should be addressed first.

If we need to do new things (like adding the do_advice member), it becomes questionable if it is worth doing. In this case, I think the update is simple enough and the control flow makes it clear what is and what isn't needed only for advice-message generation, so it might be an overall win.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.