Re: [PATCH v2 0/3] some unit-test Makefile polishing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 3, 2024, 01:32 UTC
- Message-ID
- <xmqqjznmtjr9.fsf@gitster.g>
- In-Reply-To
- <b7b92f1a-9231-2f53-299e-ad58fc699284@gmx.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> The line 753 of that file (as can be seen at > https://github.com/git/git/blob/38aa6559b0c513d755d6d5ccf32414ed63754726/config.mak.uname#L753)
Ouch. When it is laid out like this it is very obvious why this is broken, and what its workaround should be.
Thanks. Let's queue this on top.
------- >8 ------------- >8 ------------- >8 ------------- >8 ------- Subject: [PATCH] t/Makefile: say the default target upfront
Similar to how 2731d048 (Makefile: say the default target upfront., 2005-12-01) added the default target to the very beginning of the main Makefile to prevent a random rule that happens to be defined first in an included makefile fragments from becoming the default target, protect this Makefile the same way.
This started to matter as we started to include config.mak.uname and that included makefile fragment does more than defining Make macros, unfortunately.
Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/Makefile b/t/Makefile index 281f4c3534..2d95046f26 100644 --- a/t/Makefile +++ b/t/Makefile @@ -1,3 +1,6 @@ +# The default target of this Makefile is... +all:: + # Import tree-wide shared Makefile behavior and libraries include ../shared.mak @@ -52,7 +55,7 @@ UNIT_TESTS = $(sort $(filter-out unit-tests/bin/t-basic%,$(UNIT_TEST_PROGRAMS))) # scripts not to run the external "chainlint.pl" script themselves CHAINLINTSUPPRESS = GIT_TEST_EXT_CHAIN_LINT=0 && export GIT_TEST_EXT_CHAIN_LINT && -all: $(DEFAULT_TEST_TARGET) +all:: $(DEFAULT_TEST_TARGET) test: pre-clean check-chainlint $(TEST_LINT) $(CHAINLINTSUPPRESS) $(MAKE) aggregate-results-and-cleanup
-- 2.43.0-522-g2a540e432f