Re: [PATCH 2/2] t/Makefile: get UNIT_TESTS list from C sources

From: Jeff King <peff@peff.net>
Date: Jan 30, 2024, 05:25 UTC
Message-ID: <20240130052511.GC154684@coredump.intra.peff.net>
In-Reply-To: <xmqqeddzfywg.fsf@gitster.g>

On Mon, Jan 29, 2024 at 04:27:59PM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> > As a result, I'm not surprised this worked without handling $X, but I
> > don't think there's any harm in adding it either.
> 
> OK.
> 
> I wonder if something like this is sufficient?
> [...]

Yeah, that matches the patch I came up with locally. I'll roll that into v2.

Show 5 quoted lines

> I am not sure if we
> should lift the building of t/unit-tests/* up to the primary Makefile
> to mimic the way stuff related to test-tool are built and linked.
> That way, we do not have to contaminate t/Makefile with compilation
> related stuff that we didn't need originally.

I didn't quite understand this comment, though. The building of t/unit-tests _is_ in the top-level Makefile. It's just here in the recursive Makefile that we need to have the list of built programs.

-Peff