git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] credential: clear expired c->credential, unify secret clearing

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 6, 2024, 18:44 UTC
Message-ID
<xmqqjzj1lxlm.fsf@gitster.g>
In-Reply-To
<20240606183516.4077896-2-aplattner@nvidia.com>
Aaron Plattner <aplattner@nvidia.com> writes:
> v3: I reverted the behavior change to credential_reject() and just unified
> everything to use credential_clear_secrets() instead. We can rework
> credential_reject() in a later change if we decide to. So the only behavior
> change now should be the expiration case in credential_fill()
Looks good.
>
> I also updated some of the comments in credential.h to mention the new struct
> fields.

Thanks for paying attention to such details. I very much like these updated comments.

Will queue.
Previous: Aaron PlattnerNext: Jeff King
Message 2 of 3 in “credential: clear expired c->credential, unify secret clearing”
  1. credential: clear expired c->credential, unify secret clearingAaron Plattner, Jun 6, 2024
  2. Junio C HamanoJun 6, 2024
  3. Jeff KingJun 8, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.