From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 06 Jun 2024 18:44:53 GMT
Subject: Re: [PATCH v3] credential: clear expired c->credential, unify secret clearing
Message-ID: <xmqqjzj1lxlm.fsf@gitster.g>
In-Reply-To: <20240606183516.4077896-2-aplattner@nvidia.com>

Aaron Plattner <aplattner@nvidia.com> writes:

> v3: I reverted the behavior change to credential_reject() and just unified
> everything to use credential_clear_secrets() instead. We can rework
> credential_reject() in a later change if we decide to. So the only behavior
> change now should be the expiration case in credential_fill()

Looks good.

>
> I also updated some of the comments in credential.h to mention the new struct
> fields.

Thanks for paying attention to such details.  I very much like these
updated comments.

Will queue.