Re: [PATCH v4 00/25] reftable: handle allocation errors

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2024, 19:25 UTC
Message-ID: <xmqqjzervd69.fsf@gitster.g>
In-Reply-To: <7740463b-84b4-4a69-961c-278ce2901f0d@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 7 quoted lines

> Am 01.10.24 um 19:52 schrieb Junio C Hamano:
>> Shouldn't we add FREE_AND_NULL() to the banned list as well in the
>> last step?
>
> And perhaps the wrapper.h functions like xmalloc()?  At least as long as
> git-compat-util.h is included by reftable/system.h.  Can be done later,
> of course, no need to reroll just for that.

Yeah, and I agree FREE_AND_NULL() falls into the same bucket as xmalloc() and friends, so no need to reroll just for that, either.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.