From: Junio C Hamano Date: Tue, 01 Oct 2024 19:25:02 GMT Subject: Re: [PATCH v4 00/25] reftable: handle allocation errors Message-ID: In-Reply-To: <7740463b-84b4-4a69-961c-278ce2901f0d@web.de> René Scharfe writes: > Am 01.10.24 um 19:52 schrieb Junio C Hamano: >> Shouldn't we add FREE_AND_NULL() to the banned list as well in the >> last step? > > And perhaps the wrapper.h functions like xmalloc()? At least as long as > git-compat-util.h is included by reftable/system.h. Can be done later, > of course, no need to reroll just for that. Yeah, and I agree FREE_AND_NULL() falls into the same bucket as xmalloc() and friends, so no need to reroll just for that, either. Thanks.