Re: [PATCH v2 2/2] pack-objects: only perform verbatim reuse on the preferred pack

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2024, 04:44 UTC
Message-ID: <xmqqjzcvand6.fsf@gitster.g>
In-Reply-To: <d73b8fe2d63c8ad08ad0c4ffeffb5ee2509b2d50.1731591708.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

> This regression comes from ca0fd69e37 (pack-objects: prepare
> `write_reused_pack_verbatim()` for multi-pack reuse, 2023-12-14), which
> incorrectly assumed that there would be no gaps in reusable regions of
> non-preferred packs.

I was reviewing the past release notes from this year, and saw this snippet in the 2.44 release notes:

 * Streaming spans of packfile data used to be done only from a
   single, primary, pack in a repository with multiple packfiles.  It
   has been extended to allow reuse from other packfiles, too.

Essentially this two-patch series the change completely so we only reuse pack data from the primary pack?

Thanks.