Re: [PATCH 1/2] t5332-multi-pack-reuse.sh: demonstrate duplicate packing failure

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2024, 01:12 UTC
Message-ID: <xmqq8qtm8vps.fsf@gitster.g>
In-Reply-To: <7a69cf84ae5b92d99e5777d4600270712424c4d7.1731518931.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

Show 16 quoted lines

> +test_expect_failure 'duplicate objects with verbatim reuse' '
> +	git init duplicate-objects-verbatim &&
> +	(
> +		cd duplicate-objects-verbatim &&
> +
> +		git config pack.allowPackReuse multi &&
> +
> +		test_commit_bulk 64 &&
> +
> +		# take the first object from the main pack...
> +		git show-index <$(ls $packdir/pack-*.idx) >obj.raw &&
> +		sort -nk1 <obj.raw | head -n1 | cut -d" " -f2 >in &&
> +
> +		# ...and create a separate pack containing just that object
> +		p="$(git pack-objects $packdir/pack <in)" &&
> +		git show-index <$packdir/pack-$p.idx &&

Is this done so that "git show-index" fails when the .idx file fed is malformed? Or is it a leftover debugging aid, where a human developer was helped by eyeballing the contents of the .idx file in human readable form? If the latter, do we perhaps want to "parse" the output the same way in this test to validate our expectation?

Show 7 quoted lines

> +		git multi-pack-index write --bitmap --preferred-pack=pack-$p.idx &&
> +
> +		test_pack_objects_reused_all 192 2
> +	)
> +'
> +
>  test_done