Re: [PATCH 1/2] remote: allow `guess_remote_head()` to suppress advice

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 21, 2025, 08:52 UTC
Message-ID: <xmqqjz8ivk7t.fsf@gitster.g>
In-Reply-To: <Z9ukDuvsLXhYTQAP@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 14 quoted lines

> On Wed, Mar 19, 2025 at 08:46:45PM -0500, Justin Tobler wrote:
>> diff --git a/remote.h b/remote.h
>> index 6be5031f64..49c7b644bb 100644
>> --- a/remote.h
>> +++ b/remote.h
>> @@ -395,7 +395,7 @@ struct ref *get_local_heads(void);
>>   */
>>  struct ref *guess_remote_head(const struct ref *head,
>>  			      const struct ref *refs,
>> -			      int all);
>> +			      int all, int quiet);
>
> I think instead of introducing another boolean parameter it would be
> preferable to have a preparatory commit that turns `all` into `flags`.

Good. And when we turn that into a set of bits "flags", make sure we make it unsigned, not signed int.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.