Re: [PATCH 1/2] remote: allow `guess_remote_head()` to suppress advice
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Mar 20, 2025, 23:30 UTC
- Message-ID
- <rbuwquadvjmqbyhbikmupwd53xt6dpu6rpv6oyso2pscihddzw@eoovi3vqkzud>
- In-Reply-To
- <Z9ukDuvsLXhYTQAP@pks.im>
On 25/03/20 06:13AM, Patrick Steinhardt wrote:
Show 14 quoted lines
> On Wed, Mar 19, 2025 at 08:46:45PM -0500, Justin Tobler wrote: > > diff --git a/remote.h b/remote.h > > index 6be5031f64..49c7b644bb 100644 > > --- a/remote.h > > +++ b/remote.h > > @@ -395,7 +395,7 @@ struct ref *get_local_heads(void); > > */ > > struct ref *guess_remote_head(const struct ref *head, > > const struct ref *refs, > > - int all); > > + int all, int quiet); > > I think instead of introducing another boolean parameter it would be > preferable to have a preparatory commit that turns `all` into `flags`.
That makes sense. I'll adapt the next version accordingly.
Thanks, -Justin