Re: [PATCH v4 1/3] send-email: implement SMTP bearer authentication

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 23, 2025, 18:04 UTC
Message-ID: <xmqqjz7azrdk.fsf@gitster.g>
In-Reply-To: <PN3PR01MB9597776CB37BE7B05A7ADD80B8BA2@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>

Aditya Garg <gargaditya08@live.com> writes:

Show 9 quoted lines

> From: Julian Swagemakers <julian@swagemakers.org>
>
> Manually send SMTP AUTH command for auth type OAUTHBEARER and XOAUTH2.
> This is necessary since they are currently not supported by the Perls
> Authen::SASL module.
>
> The bearer token needs to be passed in as the password. This can be done
> with git-credential-oauth[0] after minor modifications[1]. Which will
> allow using git send-email with Gmail and oauth2 authentication:

I am not familiar with this area, especially with Authen::SASL, so I'd appreciate a second eye from other reviewers.

Having said that, the documentation is very clearly written, so is the above log message.

Please fold overly long lines the patch adds. We officially aim for 80-column soft limit, and we allow going over it when folding lines to stay under it makes the result less readable. But lines added to the credential callback to call smtp_bearer_auth() are a way too wide, for example [*].

Footnote [*] The text themselves are not overly wide, but the long lines there are primarily due to them deeply indented. I have to wonder if it is a sign that the part of the code needs to be a bit better refactored, e.g., by defining the callback sub defined elsewhere and passed to Git::credential() call as a variable that holds a reference to it, instead of defining an anonymous sub in place there, for example.