Re: [PATCH v6 1/1] send-email: retrieve Message-ID from outlook SMTP server
- From
Aditya Garg <gargaditya08@live.com>
- Date
- Apr 25, 2025, 19:05 UTC
- Message-ID
- <PN3PR01MB959780C23B417F287B87E61DB8842@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
- In-Reply-To
- <xmqqikmstatc.fsf@gitster.g>
On 25-04-2025 10:53 pm, Junio C Hamano wrote:
Show 16 quoted lines
> Aditya Garg <gargaditya08@live.com> writes:
>
>> +sub is_outlook {
>> + my ($host) = @_;
>> + return ($host eq 'smtp.office365.com' || $host eq 'smtp-mail.outlook.com');
>> +}
>
> There were a few messages that raised concerns with respect to
> on-prem installations of Outlook based servers, where the hostname
> cannot be used to tell if we need this message-id tweaking.
>
> The following is a completely untested patch, but it should be
> sufficient to illustrate how simple it would be to support an
> option to do so, if we cared about the issue enough.
>
> Will queue your patch _without_ this tweak, at least for now.If you really want to make it configurable, then an auto mode should also be there. In that mode, it uses my logic. I just prefer users from having more out of the box experience. By the auto mode, we can both configure it, as well as have an out of the box experience.