Re: [PATCH 2/2] builtin/mv: convert assert(3p) into `BUG()`

From: Junio C Hamano <gitster@pobox.com>
Date: May 2, 2025, 16:53 UTC
Message-ID: <xmqqjz6zuf80.fsf@gitster.g>
In-Reply-To: <38cc3249-3de2-5ed0-7ca8-bad6d4a5bea8@gmx.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> The fact of the matter is that the Visual C-built CI (first the Azure
> Pipeline, then GitHub Actions) have built the artifacts in release mode
> since forever. And the Meson addition simply made a mistake by _not
> specifying_ release mode (and hence defaulting to debug mode).

OK, so this is needed for _different_ reason; it is no longer about working around a stuck CI due to misguided test. The artifacts should be built in a particular way to be consistent with the other build pipelines (presumably they are used in production later, or something?).

If explained that way in the updated log message, I would be very happy to take the patch and merge it down, even fast-tracking down to 'maint'.

Thanks.