git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] builtin/mv: bail out when trying to move child and its parent

From
Patrick Steinhardt <ps@pks.im>
Date
Apr 30, 2025, 12:44 UTC
Message-ID
<20250430-pks-mv-parent-child-conflict-v1-0-11a87c55ffb9@pks.im>
Hi,

this series addresses a bug in git-mv(1) where moving both a child and its parent directory may cause an assert to trigger. This discussion came up in the context of [1] as the assert causes problems on our CI systems on Windows.

Thanks!
Patrick
[1]: <pull.1908.git.1745593515875.gitgitgadget@gmail.com>
---
Patrick Steinhardt (2):
      builtin/mv: bail out when trying to move child and its parent
      builtin/mv: convert assert(3p) into `BUG()`
 builtin/mv.c  | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
 t/t7001-mv.sh | 24 ++++++++++++++++++----
 2 files changed, 81 insertions(+), 7 deletions(-)

--- base-commit: 6c0bd1fc70efaf053abe4e57c976afdc72d15377 change-id: 20250430-pks-mv-parent-child-conflict-1c15f775e638

Next: Patrick Steinhardt
Message 1 of 10 in “builtin/mv: bail out when trying to move child and its parent”
  1. 0/2 builtin/mv: bail out when trying to move child and its parentPatrick Steinhardt, Apr 30, 2025
  2. 2/2 builtin/mv: convert assert(3p) into `BUG()`Patrick Steinhardt, Apr 30, 2025
  3. Junio C HamanoApr 30, 2025
  4. Junio C HamanoApr 30, 2025
  5. Patrick SteinhardtMay 2, 2025
  6. Johannes SchindelinMay 2, 2025
  7. Junio C HamanoMay 2, 2025
  8. 1/2 builtin/mv: bail out when trying to move child and its parentPatrick Steinhardt, Apr 30, 2025
  9. Junio C HamanoApr 30, 2025
  10. Patrick SteinhardtMay 2, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.