git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] t7800: fix racy "difftool --dir-diff syncs worktree" test

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 4, 2026, 02:34 UTC
Message-ID
<xmqqjyxyp0ky.fsf@gitster.g>
In-Reply-To
<pull.2149.v3.git.git.1767472809897.gitgitgadget@gmail.com>
"Paul Tarjan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> On Windows, this is more likely to manifest because Git relies on
> inode changes as a fallback when other stat fields match, but Windows
> filesystems lack inodes.
"inode" -> "inode number" (or "ino" / "inum")?

I suspect the same issue would bite users on network file systems, so while avoiding problematic scenarios in tests may improve the pass rate of the tests, we may want to fix the underlying issue with the difftool command for real in the longer term.

Regardless, will queue this updated patch.  Thanks.
Previous: Paul Tarjan via GitGitGadgetNext: Phillip Wood
Message 10 of 11 in “t7800: fix racy "difftool --dir-diff syncs worktree" test”
  1. t7800: fix racy "difftool --dir-diff syncs worktree" testPaul Tarjan via GitGitGadget, Dec 31, 2025
  2. Johannes SchindelinJan 1, 2026
  3. t7800: fix racy "difftool --dir-diff syncs worktree" testPaul Tarjan via GitGitGadget, Jan 1, 2026
  4. Junio C HamanoJan 1, 2026
  5. Phillip WoodJan 3, 2026
  6. Paul TarjanJan 3, 2026
  7. Johannes SchindelinJan 3, 2026
  8. Junio C HamanoJan 4, 2026
  9. t7800: fix racy "difftool --dir-diff syncs worktree" testPaul Tarjan via GitGitGadget, Jan 3, 2026
  10. Junio C HamanoJan 4, 2026
  11. Phillip WoodJan 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.