Re: [PATCH v2] t7800: fix racy "difftool --dir-diff syncs worktree" test

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 3, 2026, 20:29 UTC
Message-ID: <1e39f5d3-6b4a-f832-8328-f82ece12deff@gmx.de>
In-Reply-To: <CALvWuB79v3i3zU_g1swqQVS-fH1f-U8Ptr9Z9ObAUgeFJHx++A@mail.gmail.com>

Hi Paul,

On Sat, 3 Jan 2026, Paul Tarjan wrote:

> I've updated the commit and PR summary for your comments. Should I
> re-run /submit to send a no-op patch or leave it as is until code
> changes are needed?

I believe that the change you intended for v2 (adding the "Reviewed-by" trailer) accidentally made it to the cover letter only, not to the commit message where it wants to live.

Also, I would like to suggest to replace the non-URL "git-for-windows/git#5132" with the actual URL: https://github.com/git-for-windows/git/issues/5132. Remember: Commit messages are not usually read on GitHub (and some very vocal Git contributors actually refuse to use GitHub for their contributions).

Ciao, Johannes