Re: [PATCH v2 3/5] list-objects-filter: use oidmap_clear_with_free() for cleanup

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 4, 2026, 15:31 UTC
Message-ID: <xmqqjyvra9xg.fsf@gitster.g>
In-Reply-To: <aafX6qva_badx_RM@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Agreed. But I think with the current status quo I'd rather drop this
> patch though as it may otherwise make the reader scratch their head why
> we do the exercise in the first place.

I do not think too strongly either way myself, but you may be right.

Unless we are dropping the "we optionally let you free the shell" traditional interface, it is of questionable value to use the new interface.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.