Re: [PATCH v3 0/2] oidmap: migrate cleanup to oidmap_clear_with_free()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 5, 2026, 19:17 UTC
- Message-ID
- <xmqq1phy3x2h.fsf@gitster.g>
- In-Reply-To
- <20260305100526.102130-1-kuforiji98@gmail.com>
Seyi Kuforiji <kuforiji98@gmail.com> writes:
Show 24 quoted lines
> Range-diff against v2:
> 1: 1d544ef7d2 = 1: a050491441 oidmap: make entry cleanup explicit in oidmap_clear
> 2: f2c3a699bd ! 2: b592d765e3 builtin/rev-list: migrate missing_objects cleanup to oidmap_clear_with_free()
> @@ builtin/rev-list.c: static int arg_print_omitted; /* print objects omitted by fi
> unsigned type;
> };
> +
> -+static void free_missing_objects_entry(void *e)
> ++static void missing_objects_map_entry_free(void *e)
> +{
> + struct missing_objects_map_entry *entry =
> + container_of(e, struct missing_objects_map_entry, entry);
> @@ builtin/rev-list.c: int cmd_rev_list(int argc,
> }
>
> - oidmap_clear(&missing_objects, true);
> -+ oidmap_clear_with_free(&missing_objects, free_missing_objects_entry);
> ++ oidmap_clear_with_free(&missing_objects, missing_objects_map_entry_free);
> }
>
> stop_progress(&progress);
> 3: a4e426bcca < -: ---------- list-objects-filter: use oidmap_clear_with_free() for cleanup
> 4: 4116e5491d < -: ---------- odb: use oidmap_clear_with_free() to release replace_map entries
> 5: ad1f776a19 < -: ---------- sequencer: use oidmap_clear_with_free() for string_entry cleanupI think these cover everything Patrick pointed out, and I agree with what these remaining two patches do. Will queue.
Let me mark the topic for 'next'.
Thanks.