git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Discussion] t1006: testing %(rest) with object names containing whitespace

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 26, 2026, 03:41 UTC
Message-ID
<xmqqjyn5w2l2.fsf@gitster.g>
In-Reply-To
<20261026013254.GB3575069@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> So IMHO everything is working as designed, and there is nothing to fix
> in the code. But using test_expect_failure seems weird to me. It avoids
> the test suite announcing a failure, but it is not really a breakage to
> be fixed. A test with %(rest) and an object name with space should
> probably just be skipped. We _could_ run just those cases with the
> resolved id, but the point of that test is checking how %(rest) works
> with the name, so I don't know that it would be testing anything useful.

Yup, thanks for finding old (but not so old) discussion. We really should have fixed the test including the fixme comment as we knew already back then that there was nothing to fix.

Perhaps somebody involved in this discussion thread can volunteer to do so this time?

Previous: Jeff KingNext: jyotish kumar
Message 3 of 5 in “[Discussion] t1006: testing %(rest) with object names containing whitespace”
  1. jyotish kumarOct 24, 2026
  2. Jeff KingOct 26, 2026
  3. Junio C HamanoOct 26, 2026
  4. jyotish kumarOct 26, 2026
  5. t1006: skip %(rest) test for whitespace in object namesjyotishkumar725015@gmail.com, Oct 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.