From: Junio C Hamano Date: Mon, 26 Oct 2026 03:41:29 GMT Subject: Re: [Discussion] t1006: testing %(rest) with object names containing whitespace Message-ID: In-Reply-To: <20261026013254.GB3575069@coredump.intra.peff.net> Jeff King writes: > So IMHO everything is working as designed, and there is nothing to fix > in the code. But using test_expect_failure seems weird to me. It avoids > the test suite announcing a failure, but it is not really a breakage to > be fixed. A test with %(rest) and an object name with space should > probably just be skipped. We _could_ run just those cases with the > resolved id, but the point of that test is checking how %(rest) works > with the name, so I don't know that it would be testing anything useful. Yup, thanks for finding old (but not so old) discussion. We really should have fixed the test including the fixme comment as we knew already back then that there was nothing to fix. Perhaps somebody involved in this discussion thread can volunteer to do so this time?