git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] t: add "test-tool genbytes" to avoid slow tr(1) on macOS

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 7, 2026, 23:23 UTC
Message-ID
<xmqqjymo8bv6.fsf@gitster.g>
In-Reply-To
<pull.2301.git.1794063565.gitgitgadget@gmail.com>

"Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Open question: is patch 3 wanted? It folds "genzeros" into "genbytes",
> spelling the NUL byte as "NUL", so that there is a single command.

I would suggest genbytes to take the value of the byte in decimal or hex, instead of av[1][0], so that you do not have to treat NUL any specially. I would actually think it is even better to limit the input format only to [0-9a-f][0-9a-f], i.e., two hexadecimal digits that does not allow uppercase to represent values 0-255 (inclusive), without support for any other input format like decimal.

After all, this is just a test helper, so ergonomics or flexibility do not matter as much as simplicity.

Show 7 quoted lines
> Some other decisions that may be worth pointing out:
>
>  * The buffer is no longer static: it used to be static so that it was
>    zero-initialized for free, but now that it is filled with the requested
>    byte on every call, a local buffer avoids shared state. It keeps its size
>    of 256KB. Smaller buffers made no measurable difference in my tests, but
>    there was no reason to change it.
Shouldn't matter.
>  * Invalid counts are still silently treated as 0, as before. That could be
>    tightened, but it is unrelated to this series.

Shouldn't matter. That's ergonomics and flexibility that we do not value as much as in a normal program.

Thanks.
Previous: Kristofer KarlssonNext: Kristofer Karlsson
Message 23 of 39 in “t: add "test-tool genbytes" to avoid slow tr(1) on macOS”
  1. 0/3 t: add "test-tool genbytes" to avoid slow tr(1) on macOSKristofer Karlsson via GitGitGadget, Nov 7, 2026
  2. 1/3 t/helper: rename test-genzeros.c to test-genbytes.cKristofer Karlsson via GitGitGadget, Nov 7, 2026
  3. Junio C HamanoNov 7, 2026
  4. Junio C HamanoNov 8, 2026
  5. Kristofer KarlssonNov 8, 2026
  6. Junio C HamanoNov 8, 2026
  7. Kristofer KarlssonNov 8, 2026
  8. 2/3 t: add "test-tool genbytes" to avoid slow tr(1) on macOSKristofer Karlsson via GitGitGadget, Nov 7, 2026
  9. Johannes SixtNov 8, 2026
  10. Kristofer KarlssonNov 8, 2026
  11. Johannes SixtNov 8, 2026
  12. Kristofer KarlssonNov 8, 2026
  13. Johannes SixtNov 8, 2026
  14. Johannes SixtNov 9, 2026
  15. Kristofer KarlssonNov 9, 2026
  16. Johannes SixtNov 9, 2026
  17. Collin FunkNov 10, 2026
  18. Kristofer KarlssonNov 10, 2026
  19. Junio C HamanoNov 8, 2026
  20. 3/3 t: replace "test-tool genzeros" with "genbytes NUL"Kristofer Karlsson via GitGitGadget, Nov 7, 2026
  21. Junio C HamanoNov 7, 2026
  22. Kristofer KarlssonNov 8, 2026
  23. Junio C HamanoNov 7, 2026
  24. Kristofer KarlssonNov 8, 2026
  25. 0/2 t: add "test-tool genbytes" to avoid slow tr(1) on macOSKristofer Karlsson via GitGitGadget, Nov 8, 2026
  26. 1/2 t: add "test-tool genbytes" to avoid slow tr(1) on macOSKristofer Karlsson via GitGitGadget, Nov 8, 2026
  27. Junio C HamanoNov 9, 2026
  28. Kristofer KarlssonNov 9, 2026
  29. Junio C HamanoNov 9, 2026
  30. Patrick SteinhardtNov 9, 2026
  31. Kristofer KarlssonNov 9, 2026
  32. 2/2 t: replace "test-tool genzeros" with "genbytes 00"Kristofer Karlsson via GitGitGadget, Nov 8, 2026
  33. t: add "test-tool genbytes" to avoid slow tr(1) on macOSKristofer Karlsson via GitGitGadget, Nov 10, 2026
  34. Junio C HamanoNov 10, 2026
  35. Patrick SteinhardtNov 11, 2026
  36. Junio C HamanoNov 11, 2026
  37. Kristofer KarlssonNov 11, 2026
  38. Junio C HamanoNov 11, 2026
  39. t: add "test-tool genbytes" to avoid slow tr(1) on macOSKristofer Karlsson via GitGitGadget, Nov 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.