Re: [PATCH v3] t: add "test-tool genbytes" to avoid slow tr(1) on macOS
- From
Kristofer Karlsson <krka@spotify.com>
- Date
- Nov 11, 2026, 15:47 UTC
- Message-ID
- <CAL71e4N2T0XLZgnUVPEk1q8JjRiWbRo5B47DN_hfs1CreYH6Jg@mail.gmail.com>
- In-Reply-To
- <xmqqse17nztl.fsf@gitster.g>
On Wed, 11 Nov 2026 at 16:38, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> > "Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com> > writes: > > > From: Kristofer Karlsson <krka@spotify.com> > > > > Several tests create fixture data consisting of a single repeated > > character with "test-tool genzeros <count> | tr '\000' <char>". This > > works well on platforms where tr(1) is implemented efficiently. > > This looks good as-is, but once we merge this down, we will find > that there is a new use of the pattern that pipes test-tool genzeros > into tr in t/t1600-index.sh recently merged as part of the Git > 2.50.2 update. > > Perhaps we should rebase to catch that callsite? > > Thanks. >
Oh that was unlucky timing, but easy to fix. Not only is this new test using tr, it's also using very large values. I'll submit a v4 rebased on latest master, which should fix it.
Thanks, Kristofer