git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 1/7] replace: forbid replacing an object with one of a different type

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 6, 2013, 21:34 UTC
Message-ID
<xmqqioydws6d.fsf@gitster.dls.corp.google.com>
In-Reply-To
<xmqqmwnpwv6m.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> Christian Couder <chriscool@tuxfamily.org> writes:
>
>> +	obj_type = sha1_object_info(object, NULL);
>> +	repl_type = sha1_object_info(repl, NULL);
>
> That we can do this is somewhat curious....

Note that this was a comment on the sha1_object_info() API, which, unlike read_sha1_file() API, does not seem to interact with the "replace" mechanism. I _think_ that needs to be rethought by checking each call site, but for the purpose of this series, I think this is the best we can do in this patch.

Will queue the whole series.
Thanks.
Previous: Junio C HamanoNext: Christian Couder
Message 4 of 10 in “Check replacement object type and minor updates”
  1. 0/7 Check replacement object type and minor updatesChristian Couder, Sep 6, 2013
  2. 1/7 replace: forbid replacing an object with one of a different typeChristian Couder, Sep 6, 2013
  3. Junio C HamanoSep 6, 2013
  4. Junio C HamanoSep 6, 2013
  5. 2/7 Documentation/replace: state that objects must be of the same typeChristian Couder, Sep 6, 2013
  6. 3/7 t6050-replace: test that objects are of the same typeChristian Couder, Sep 6, 2013
  7. 4/7 t6050-replace: add test to clean up all the replace refsChristian Couder, Sep 6, 2013
  8. 5/7 Documentation/replace: add Creating Replacement Objects sectionChristian Couder, Sep 6, 2013
  9. 6/7 replace: allow long option namesChristian Couder, Sep 6, 2013
  10. 7/7 t6050-replace: use some long option namesChristian Couder, Sep 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.