From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 06 Sep 2013 21:34:18 GMT
Subject: Re: [PATCH v5 1/7] replace: forbid replacing an object with one of a different type
Message-ID: <xmqqioydws6d.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqmwnpwv6m.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Christian Couder <chriscool@tuxfamily.org> writes:
>
>> +	obj_type = sha1_object_info(object, NULL);
>> +	repl_type = sha1_object_info(repl, NULL);
>
> That we can do this is somewhat curious....

Note that this was a comment on the sha1_object_info() API, which,
unlike read_sha1_file() API, does not seem to interact with the
"replace" mechanism.  I _think_ that needs to be rethought by
checking each call site, but for the purpose of this series, I think
this is the best we can do in this patch.

Will queue the whole series.

Thanks.