git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 18, 2013, 17:37 UTC
Message-ID
<xmqqioumjc1n.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAP8UFD3UsdcDg2D2nysMZgGAxLebYm-qQX3LZfqdwF9gNbyxgA@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 9 quoted lines
> On Wed, Dec 18, 2013 at 1:37 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
>> Am 11.12.2013 08:46, schrieb Christian Couder:
>>> +enum repl_fmt { SHORT, MEDIUM, FULL };
>>
>> SHORT is predefined on Windows, could you choose another name?
>
> Ok, I will change to:
>
> enum repl_fmt { SHORT_FMT, MEDIUM_FMT, FULL_FMT };

What are these for in the first place? Your "SHORT" conflicting with something totally unrelated is a sign that you should be naming them in a way that is more specific to your use. SHORT_FMT is still not specific enough to tell what they are for. With SHOW_REPLACE_ prefix, perhaps? Also perhaps give characterization better than their output lengths?

My quick read of show_reference() tells me that they are "name only", "name and value", and something else that does not seem very useful unless you are debugging.

Previous: Christian CouderNext: Christian Couder
Message 11 of 20 in “teach replace objects to sha1_object_info_extended()”
  1. 00/10 teach replace objects to sha1_object_info_extended()Christian Couder, Dec 11, 2013
  2. 01/10 Rename READ_SHA1_FILE_REPLACE flag to LOOKUP_REPLACE_OBJECTChristian Couder, Dec 11, 2013
  3. 02/10 replace_object: don't check read_replace_refs twiceChristian Couder, Dec 11, 2013
  4. 03/10 Introduce lookup_replace_object_extended() to pass flagsChristian Couder, Dec 11, 2013
  5. 04/10 Add an "unsigned flags" parameter to sha1_object_info_extended()Christian Couder, Dec 11, 2013
  6. 05/10 t6050: show that git cat-file --batch fails with replace objectsChristian Couder, Dec 11, 2013
  7. 06/10 sha1_file: perform object replacement in sha1_object_info_extended()Christian Couder, Dec 11, 2013
  8. 07/10 builtin/replace: teach listing using short, medium or full formatsChristian Couder, Dec 11, 2013
  9. Karsten BleesDec 18, 2013
  10. Christian CouderDec 18, 2013
  11. Junio C HamanoDec 18, 2013
  12. Christian CouderDec 19, 2013
  13. Junio C HamanoDec 19, 2013
  14. Christian CouderDec 21, 2013
  15. Junio C HamanoDec 26, 2013
  16. Christian CouderDec 28, 2013
  17. 08/10 t6050: add tests for listing with --formatChristian Couder, Dec 11, 2013
  18. 09/10 builtin/replace: unset read_replace_refsChristian Couder, Dec 11, 2013
  19. 10/10 Documentation/git-replace: describe --format optionChristian Couder, Dec 11, 2013
  20. Junio C HamanoDec 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.