git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2014, 18:07 UTC
Message-ID
<xmqqiopqg08a.fsf@gitster.dls.corp.google.com>
In-Reply-To
<vpq4n1alqf2.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 12 quoted lines
> Patches 1/14 are
>
> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
>
> On a side note, reviewing patches by batches of 14 patches actually
> turns out to be much less convenient for me than reviewing larger
> batches.
>
> If I'm counting correctly, there should be around 100 patches remaining.
> I'd suggest that the next batch contain them all (probably publishing
> the branch somewhere and posting a merge request here would be better to
> avoid sending 100 mails).

I eyeballed these 28 patches so far (but not this round yet) and each of the batches did fit my attention span for a series while looking at other topics also in flight. Tastes and preferences differ between us, I guess.

I however can, and am very inclined to, trust your review blindly and apply further patches on this topic with your Reviewed-by: without even looking at the patches myself. If "give us the whole" is more convenient for you, I am perfectly happy with that approach.

Thanks for reviewing.
Previous: Matthieu Moy
Message 16 of 16 in “t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution”
  1. 01/14 t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  2. 02/14 t3910-mac-os-precompose.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  3. 03/14 t4006-diff-mode.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  4. 04/14 t4010-diff-pathspec.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  5. 05/14 t4012-diff-binary.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  6. 06/14 t4013-diff-various.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  7. 07/14 t4014-format-patch.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  8. 08/14 t4036-format-patch-signer-mime.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  9. 09/14 t4038-diff-combined.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  10. 10/14 t4057-diff-combined-paths.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  11. 11/14 t4116-apply-reverse.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  12. 12/14 t4119-apply-config.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  13. 13/14 t4204-patch-id.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  14. 14/14 t5000-tar-tree.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  15. Matthieu MoyApr 30, 2014
  16. Junio C HamanoApr 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.