git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/14] t4012-diff-binary.sh: use the $( ... ) construct for command substitution

From
Elia Pinto <gitter.spiros@gmail.com>
Date
Apr 30, 2014, 16:22 UTC
Message-ID
<1398874987-14873-5-git-send-email-gitter.spiros@gmail.com>
In-Reply-To
<1398874987-14873-1-git-send-email-gitter.spiros@gmail.com>

The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character.

The patch was generated by:
for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t4012-diff-binary.sh |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
index 1215ae5..643d729 100755
--- a/t/t4012-diff-binary.sh
+++ b/t/t4012-diff-binary.sh
@@ -67,18 +67,18 @@ test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '
 	git diff >output &&
 	sed -e "s/-CIT/xCIT/" <output >broken &&
 	test_must_fail git apply --stat --summary broken 2>detected &&
-	detected=`cat detected` &&
-	detected=`expr "$detected" : "fatal.*at line \\([0-9]*\\)\$"` &&
-	detected=`sed -ne "${detected}p" broken` &&
+	detected=$(cat detected) &&
+	detected=$(expr "$detected" : "fatal.*at line \\([0-9]*\\)\$") &&
+	detected=$(sed -ne "${detected}p" broken) &&
 	test "$detected" = xCIT
 '
 
 test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '
 	git diff --binary | sed -e "s/-CIT/xCIT/" >broken &&
 	test_must_fail git apply --stat --summary broken 2>detected &&
-	detected=`cat detected` &&
-	detected=`expr "$detected" : "fatal.*at line \\([0-9]*\\)\$"` &&
-	detected=`sed -ne "${detected}p" broken` &&
+	detected=$(cat detected) &&
+	detected=$(expr "$detected" : "fatal.*at line \\([0-9]*\\)\$") &&
+	detected=$(sed -ne "${detected}p" broken) &&
 	test "$detected" = xCIT
 '
 
@@ -88,7 +88,7 @@ test_expect_success 'initial commit' 'git commit -a -m initial'
 test_expect_success 'diff-index with --binary' '
 	echo AIT >a && mv b e && echo CIT >c && cat e >d &&
 	git update-index --add --remove a b c d e &&
-	tree0=`git write-tree` &&
+	tree0=$(git write-tree) &&
 	git diff --cached --binary >current &&
 	git apply --stat --summary current
 '
@@ -96,7 +96,7 @@ test_expect_success 'diff-index with --binary' '
 test_expect_success 'apply binary patch' '
 	git reset --hard &&
 	git apply --binary --index <current &&
-	tree1=`git write-tree` &&
+	tree1=$(git write-tree) &&
 	test "$tree1" = "$tree0"
 '
 
-- 
1.7.10.4
Previous: Elia PintoNext: Elia Pinto
Message 5 of 16 in “t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution”
  1. 01/14 t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  2. 02/14 t3910-mac-os-precompose.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  3. 03/14 t4006-diff-mode.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  4. 04/14 t4010-diff-pathspec.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  5. 05/14 t4012-diff-binary.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  6. 06/14 t4013-diff-various.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  7. 07/14 t4014-format-patch.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  8. 08/14 t4036-format-patch-signer-mime.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  9. 09/14 t4038-diff-combined.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  10. 10/14 t4057-diff-combined-paths.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  11. 11/14 t4116-apply-reverse.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  12. 12/14 t4119-apply-config.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  13. 13/14 t4204-patch-id.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  14. 14/14 t5000-tar-tree.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 30, 2014
  15. Matthieu MoyApr 30, 2014
  16. Junio C HamanoApr 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.