git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 11/16] trace: add 'file:line' to all trace output

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 2, 2014, 18:57 UTC
Message-ID
<xmqqionfh9lp.fsf@gitster.dls.corp.google.com>
In-Reply-To
<53B33DED.3030809@gmail.com>
Karsten Blees <karsten.blees@gmail.com> writes:
Show 11 quoted lines
> +#else
> +
> +/*
> + * Macros to add file:line - see above for C-style declarations of how these
> + * should be used.
> + *
> + * TRACE_CONTEXT may be set to __FUNCTION__ if the compiler supports it. The
> + * default is __FILE__, as it is consistent with assert(), and static function
> + * names are not necessarily unique.
> + */
> +#define TRACE_CONTEXT __FILE__

Hmph, seeing "may be set to" forces me to wonder how. Perhaps #ifndef/#endif around it?

Also, can it be set to something like __FILE__ ":" __FUNCTION__ which may alleviate the alleged problem of "not necessarily unique" perhaps?

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Karsten BleesNext: Karsten Blees
Message 14 of 21 in “add performance tracing facility”
  1. 00/16 add performance tracing facilityKarsten Blees, Jul 1, 2014
  2. 01/16 trace: move trace declarations from cache.h to new trace.hKarsten Blees, Jul 1, 2014
  3. 02/16 trace: consistently name the format parameterKarsten Blees, Jul 1, 2014
  4. 03/16 trace: remove redundant printf format attributeKarsten Blees, Jul 1, 2014
  5. 04/16 trace: improve trace performanceKarsten Blees, Jul 1, 2014
  6. Junio C HamanoJul 2, 2014
  7. 05/16 Documentation/git.txt: improve documentation of 'GIT_TRACE*' variablesKarsten Blees, Jul 1, 2014
  8. 06/16 sha1_file: change GIT_TRACE_PACK_ACCESS logging to use trace APIKarsten Blees, Jul 1, 2014
  9. 07/16 trace: add infrastructure to augment trace output with additional infoKarsten Blees, Jul 1, 2014
  10. 08/16 trace: disable additional trace output for unit testsKarsten Blees, Jul 1, 2014
  11. 09/16 trace: add current timestamp to all trace outputKarsten Blees, Jul 1, 2014
  12. 10/16 trace: move code around, in preparation to file:line outputKarsten Blees, Jul 1, 2014
  13. 11/16 trace: add 'file:line' to all trace outputKarsten Blees, Jul 1, 2014
  14. Junio C HamanoJul 2, 2014
  15. Karsten BleesJul 2, 2014
  16. Junio C HamanoJul 2, 2014
  17. 12/16 trace: add high resolution timer function to debug performance issuesKarsten Blees, Jul 1, 2014
  18. 13/16 trace: add trace_performance facility to debug performance issuesKarsten Blees, Jul 1, 2014
  19. 14/16 git: add performance tracing for git's main() function to debug scriptsKarsten Blees, Jul 1, 2014
  20. 15/16 wt-status: simplify performance measurement by using getnanotime()Karsten Blees, Jul 1, 2014
  21. 16/16 progress: simplify performance measurement by using getnanotime()Karsten Blees, Jul 1, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.