git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 09/16] trace: add current timestamp to all trace output

From
Karsten Blees <karsten.blees@gmail.com>
Date
Jul 1, 2014, 23:00 UTC
Message-ID
<53B33DA3.2070106@gmail.com>
In-Reply-To
<53B33C05.5090900@gmail.com>
This is useful to tell apart trace output of separate test runs.

It can also be used for basic, coarse-grained performance analysis. Note that the accuracy is tainted by writing to the trace file, and you have to calculate the deltas yourself (which is next to impossible if multiple threads or processes are involved).

Signed-off-by: Karsten Blees <blees@dcon.de>
---
 trace.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/trace.c b/trace.c
index a194b16..18e5d93 100644
--- a/trace.c
+++ b/trace.c
@@ -88,6 +88,9 @@ static const char err_msg[] = "Could not trace into fd given by "
 static int prepare_trace_line(struct trace_key *key, struct strbuf *buf)
 {
 	static struct trace_key trace_bare = TRACE_KEY_INIT(BARE);
+	struct timeval tv;
+	struct tm tm;
+	time_t secs;
 
 	if (!trace_want(key))
 		return 0;
@@ -98,7 +101,12 @@ static int prepare_trace_line(struct trace_key *key, struct strbuf *buf)
 	if (trace_want(&trace_bare))
 		return 1;
 
-	/* add line prefix here */
+	/* print current timestamp */
+	gettimeofday(&tv, NULL);
+	secs = tv.tv_sec;
+	localtime_r(&secs, &tm);
+	strbuf_addf(buf, "%02d:%02d:%02d.%06ld ", tm.tm_hour, tm.tm_min,
+		    tm.tm_sec, (long) tv.tv_usec);
 
 	return 1;
 }
-- 
2.0.0.406.ge74f8ff

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Karsten BleesNext: Karsten Blees
Message 11 of 21 in “add performance tracing facility”
  1. 00/16 add performance tracing facilityKarsten Blees, Jul 1, 2014
  2. 01/16 trace: move trace declarations from cache.h to new trace.hKarsten Blees, Jul 1, 2014
  3. 02/16 trace: consistently name the format parameterKarsten Blees, Jul 1, 2014
  4. 03/16 trace: remove redundant printf format attributeKarsten Blees, Jul 1, 2014
  5. 04/16 trace: improve trace performanceKarsten Blees, Jul 1, 2014
  6. Junio C HamanoJul 2, 2014
  7. 05/16 Documentation/git.txt: improve documentation of 'GIT_TRACE*' variablesKarsten Blees, Jul 1, 2014
  8. 06/16 sha1_file: change GIT_TRACE_PACK_ACCESS logging to use trace APIKarsten Blees, Jul 1, 2014
  9. 07/16 trace: add infrastructure to augment trace output with additional infoKarsten Blees, Jul 1, 2014
  10. 08/16 trace: disable additional trace output for unit testsKarsten Blees, Jul 1, 2014
  11. 09/16 trace: add current timestamp to all trace outputKarsten Blees, Jul 1, 2014
  12. 10/16 trace: move code around, in preparation to file:line outputKarsten Blees, Jul 1, 2014
  13. 11/16 trace: add 'file:line' to all trace outputKarsten Blees, Jul 1, 2014
  14. Junio C HamanoJul 2, 2014
  15. Karsten BleesJul 2, 2014
  16. Junio C HamanoJul 2, 2014
  17. 12/16 trace: add high resolution timer function to debug performance issuesKarsten Blees, Jul 1, 2014
  18. 13/16 trace: add trace_performance facility to debug performance issuesKarsten Blees, Jul 1, 2014
  19. 14/16 git: add performance tracing for git's main() function to debug scriptsKarsten Blees, Jul 1, 2014
  20. 15/16 wt-status: simplify performance measurement by using getnanotime()Karsten Blees, Jul 1, 2014
  21. 16/16 progress: simplify performance measurement by using getnanotime()Karsten Blees, Jul 1, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.