git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] notes: Allow treeish expressions as notes ref

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 13, 2015, 21:15 UTC
Message-ID
<xmqqio9nzrlh.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150713205304.GA26911@glandium.org>
Mike Hommey <mh@glandium.org> writes:
Show 6 quoted lines
>>  - Make sure that we show "there is no such tree-ish, no way to look
>>    up any note to any commit from there" and "I understood the tree
>>    you gave me, but there is no note for that commit" differently.
>
> How would you reconcile that with the usual "there are only a couple
> commits with a note in the hundreds you make me display"?

I am talking about the difference between "a tree exists (which may lack notes for a given commit)" and "a tree does not even exist in the first place". This patch removed "a tree exists but that is not a ref so we silently ignore", but I do not know if that change alone covers everything---do you?

Show 5 quoted lines
>>  - Decide if we want to "fail" the operation when the notes tree
>>    given by the user is not even a tree-ish or just "warn" and keep
>>    going.  And do so consistently.
>
> Is this something you want to be figured before merging this patch?

Depends on the definition of 'merging'. I queued this one on 'pu', and have no intention to merge it down to 'master' by the end of this month; in the meantime either incremental or replacement refinement can certainly address that inconsistency I'd hope ;-)

Thanks.
Previous: Mike HommeyNext: Mike Hommey
Message 15 of 22 in “notes: Use get_sha1_committish instead of read_ref in init_notes()”
  1. notes: Use get_sha1_committish instead of read_ref in init_notes()Mike Hommey, Jun 17, 2015
  2. Junio C HamanoJun 17, 2015
  3. Mike HommeyJun 17, 2015
  4. Junio C HamanoJun 17, 2015
  5. Johan HerlandJun 17, 2015
  6. notes: Allow committish expressions as notes refMike Hommey, Jul 8, 2015
  7. notes: Allow committish expressions as notes refMike Hommey, Jul 9, 2015
  8. Johan HerlandJul 10, 2015
  9. notes: Allow treeish expressions as notes refMike Hommey, Jul 10, 2015
  10. Johan HerlandJul 10, 2015
  11. Mike HommeyJul 10, 2015
  12. notes: Allow treeish expressions as notes refMike Hommey, Jul 10, 2015
  13. Junio C HamanoJul 13, 2015
  14. Mike HommeyJul 13, 2015
  15. Junio C HamanoJul 13, 2015
  16. Mike HommeyOct 8, 2015
  17. notes: allow treeish expressions as notes refMike Hommey, Oct 8, 2015
  18. Junio C HamanoOct 8, 2015
  19. Junio C HamanoJul 13, 2015
  20. Jeff KingJun 17, 2015
  21. Mike HommeyJun 17, 2015
  22. Jeff KingJun 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.