git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes()

From
Jeff King <peff@peff.net>
Date
Jun 17, 2015, 16:35 UTC
Message-ID
<20150617163536.GA22689@peff.net>
In-Reply-To
<20150617090246.GC30948@glandium.org>
On Wed, Jun 17, 2015 at 06:02:46PM +0900, Mike Hommey wrote:
Show 13 quoted lines
> > In a sense that is weirdly broken already:
> > 
> >   $ git log --notes=:/foo >/dev/null
> >   warning: notes ref refs/notes/:/foo is invalid
> > 
> > but I wonder if we should be making expand_notes_ref a little more
> > careful as part of the same topic.
> 
> Interestingly, now that I look, there's also this:
> https://github.com/git/git/blob/master/notes-cache.c#L40
> 
> that doesn't use expand_notes_ref, but it's apparently only used in
> userdiff_get_textconv, and I'm not sure why.

notes-cache.c predates expand_notes_ref. I don't think it's a big deal. The implementation of notes-cache is an internal detail (the user interacts with it by setting diff.*.cacheTextConv, and then git handles the cache).

-Peff
Previous: Mike Hommey
Message 22 of 22 in “notes: Use get_sha1_committish instead of read_ref in init_notes()”
  1. notes: Use get_sha1_committish instead of read_ref in init_notes()Mike Hommey, Jun 17, 2015
  2. Junio C HamanoJun 17, 2015
  3. Mike HommeyJun 17, 2015
  4. Junio C HamanoJun 17, 2015
  5. Johan HerlandJun 17, 2015
  6. notes: Allow committish expressions as notes refMike Hommey, Jul 8, 2015
  7. notes: Allow committish expressions as notes refMike Hommey, Jul 9, 2015
  8. Johan HerlandJul 10, 2015
  9. notes: Allow treeish expressions as notes refMike Hommey, Jul 10, 2015
  10. Johan HerlandJul 10, 2015
  11. Mike HommeyJul 10, 2015
  12. notes: Allow treeish expressions as notes refMike Hommey, Jul 10, 2015
  13. Junio C HamanoJul 13, 2015
  14. Mike HommeyJul 13, 2015
  15. Junio C HamanoJul 13, 2015
  16. Mike HommeyOct 8, 2015
  17. notes: allow treeish expressions as notes refMike Hommey, Oct 8, 2015
  18. Junio C HamanoOct 8, 2015
  19. Junio C HamanoJul 13, 2015
  20. Jeff KingJun 17, 2015
  21. Mike HommeyJun 17, 2015
  22. Jeff KingJun 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.