git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/4] submodule config lookup API

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 12, 2015, 17:53 UTC
Message-ID
<xmqqio8kl7ex.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAGZ79kakGg6Ejworq5xVr2QuzLHxh=E6tzU_PoW+0M6AWuKJfg@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
> On Mon, Jun 15, 2015 at 2:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Thanks.  Will replace and wait for comments from others.
>
> I have reviewed the patches carefully and they look good to me.

OK, I recall there were a few iterations with review comments before this round. Is it your impression that they have been addressed adequately?

Do you prefer it to be rebased to a more recent 'master' before you build your work on top of it (I think the topic currently builds on top of v2.5.0-rc0~56)?

Thanks.
Previous: Stefan Beller
Message 16 of 16 in “submodule config lookup API”
  1. 0/4 submodule config lookup APIHeiko Voigt, Jun 15, 2015
  2. 1/4 implement submodule config API for lookup of .gitmodules valuesHeiko Voigt, Jun 15, 2015
  3. Heiko VoigtJun 16, 2015
  4. Phil HordJul 8, 2015
  5. Heiko VoigtJul 9, 2015
  6. Jeff KingJul 9, 2015
  7. Jens LehmannJul 9, 2015
  8. Junio C HamanoJul 9, 2015
  9. Heiko VoigtJul 13, 2015
  10. Junio C HamanoJul 13, 2015
  11. 2/4 extract functions for submodule config set and lookupHeiko Voigt, Jun 15, 2015
  12. 3/4 use new config API for worktree configurations of submodulesHeiko Voigt, Jun 15, 2015
  13. 4/4 do not die on error of parsing fetchrecursesubmodules optionHeiko Voigt, Jun 15, 2015
  14. Junio C HamanoJun 15, 2015
  15. Stefan BellerAug 10, 2015
  16. Junio C HamanoAug 12, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.