git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/4] submodule config lookup API

From
Stefan Beller <sbeller@google.com>
Date
Aug 10, 2015, 19:23 UTC
Message-ID
<CAGZ79kakGg6Ejworq5xVr2QuzLHxh=E6tzU_PoW+0M6AWuKJfg@mail.gmail.com>
In-Reply-To
<xmqq8ubk7idb.fsf@gitster.dls.corp.google.com>
On Mon, Jun 15, 2015 at 2:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Thanks.  Will replace and wait for comments from others.
I have reviewed the patches carefully and they look good to me.

As Git is a large project and I was active in other parts until now, I noticed that there are subtle differences in style as when compared to the refs code. One example would be the way comments are written. In d378e35d256348f (Patch 1, implement submodule config API for lookup of .gitmodules values) the comments for the data structures in submodule-config.c seem to have a non exposed "headline" and if more is needed proper sentences with capitalized starts and punctuation at the end. In the refs code there are only sentences IIRC. Most of the commits touching submodule.{c,h} do not prefix their commit message with "submodule:"

The style is no show stopper of course, just an observation from someone moving into a different area of code.

Thanks, Stefan

Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 16 in “submodule config lookup API”
  1. 0/4 submodule config lookup APIHeiko Voigt, Jun 15, 2015
  2. 1/4 implement submodule config API for lookup of .gitmodules valuesHeiko Voigt, Jun 15, 2015
  3. Heiko VoigtJun 16, 2015
  4. Phil HordJul 8, 2015
  5. Heiko VoigtJul 9, 2015
  6. Jeff KingJul 9, 2015
  7. Jens LehmannJul 9, 2015
  8. Junio C HamanoJul 9, 2015
  9. Heiko VoigtJul 13, 2015
  10. Junio C HamanoJul 13, 2015
  11. 2/4 extract functions for submodule config set and lookupHeiko Voigt, Jun 15, 2015
  12. 3/4 use new config API for worktree configurations of submodulesHeiko Voigt, Jun 15, 2015
  13. 4/4 do not die on error of parsing fetchrecursesubmodules optionHeiko Voigt, Jun 15, 2015
  14. Junio C HamanoJun 15, 2015
  15. Stefan BellerAug 10, 2015
  16. Junio C HamanoAug 12, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.