Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 19, 2016, 18:13 UTC
Message-ID: <xmqqinx5vyg5.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <BC5163B8-7CF2-4106-9FBE-8CCD096252A2@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 13 quoted lines

> This seems to fix the issue:
>
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -2274,7 +2274,7 @@ class P4Sync(Command, P4UserMap):
>          self.useClientSpec_from_options = False
>          self.clientSpecDirs = None
>          self.tempBranches = []
> -        self.tempBranchLocation = "git-p4-tmp"
> +        self.tempBranchLocation = "refs/heads/git-p4-tmp"
>          self.largeFileSystem = None
>  
>          if gitConfig('git-p4.largeFileSystem'):

Anywhere in refs/ would be OK, but don't you need to adjust the test, too?

Even though I do not use git-p4, I'd imagine that I would be upset if temporary refs that are used only during sync contaminated the set of local branches I have, if I were a user of git-p4. Would it make sense to use "refs/git-p4-tmp" or something instead?