git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

From
Lars Schneider <larsxschneider@gmail.com>
Date
Jun 19, 2016, 18:53 UTC
Message-ID
<CD2C5DC4-C11B-4D80-8C6F-254DCD30CD02@gmail.com>
In-Reply-To
<D0F4EDD7-43BB-4311-A8C9-7A83E45CACC6@gmail.com>
Show 29 quoted lines
> On 19 Jun 2016, at 20:49, Lars Schneider <larsxschneider@gmail.com> wrote:
> 
> 
>> On 19 Jun 2016, at 20:13, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Lars Schneider <larsxschneider@gmail.com> writes:
>> 
>>> This seems to fix the issue:
>>> 
>>> --- a/git-p4.py
>>> +++ b/git-p4.py
>>> @@ -2274,7 +2274,7 @@ class P4Sync(Command, P4UserMap):
>>>        self.useClientSpec_from_options = False
>>>        self.clientSpecDirs = None
>>>        self.tempBranches = []
>>> -        self.tempBranchLocation = "git-p4-tmp"
>>> +        self.tempBranchLocation = "refs/heads/git-p4-tmp"
>>>        self.largeFileSystem = None
>>> 
>>>        if gitConfig('git-p4.largeFileSystem'):
>> 
>> Anywhere in refs/ would be OK, but don't you need to adjust the
>> test, too?
>> 
>> Even though I do not use git-p4, I'd imagine that I would be upset
>> if temporary refs that are used only during sync contaminated the
>> set of local branches I have, if I were a user of git-p4.  Would it
>> make sense to use "refs/git-p4-tmp" or something instead?
> Yes, "refs/git-p4-tmp" would work equally well.

Plus, you are right. A minor test adjustment is necessary (although the tests pass without adjustment). I will post a full patch.

- Lars
Previous: Lars SchneiderNext: Junio C Hamano
Message 12 of 31 in “What's cooking in git.git (Jun 2016, #05; Thu, 16)”
  1. Junio C HamanoJun 17, 2016
  2. Pranit BauvaJun 17, 2016
  3. Vasco AlmeidaJun 17, 2016
  4. Lars SchneiderJun 17, 2016
  5. Junio C HamanoJun 17, 2016
  6. Michael HaggertyJun 18, 2016
  7. Michael HaggertyJun 19, 2016
  8. Lars SchneiderJun 19, 2016
  9. Lars SchneiderJun 19, 2016
  10. Junio C HamanoJun 19, 2016
  11. Lars SchneiderJun 19, 2016
  12. Lars SchneiderJun 19, 2016
  13. Junio C HamanoJun 19, 2016
  14. Junio C HamanoJun 19, 2016
  15. Lars SchneiderJun 20, 2016
  16. Michael HaggertyJun 23, 2016
  17. Lars SchneiderJun 27, 2016
  18. Junio C HamanoJun 27, 2016
  19. Michael HaggertyJun 28, 2016
  20. Junio C HamanoJun 28, 2016
  21. Michael HaggertyJun 18, 2016
  22. Junio C HamanoJun 18, 2016
  23. Michael HaggertyJun 19, 2016
  24. Junio C HamanoJun 19, 2016
  25. Torsten BögershausenJun 20, 2016
  26. Junio C HamanoJun 20, 2016
  27. Joey HessJun 22, 2016
  28. Torsten BögershausenJun 23, 2016
  29. Joey HessJul 12, 2016
  30. Torsten BögershausenJul 14, 2016
  31. Junio C HamanoJul 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.