Re: [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2017, 23:16 UTC
Message-ID: <xmqqinotmrhe.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170201230753.19462-1-cornelius.weig@tngtech.com>

cornelius.weig@tngtech.com writes:

Show 12 quoted lines

> From: Cornelius Weig <cornelius.weig@tngtech.com>
>
> Add documentation for the `--recurse-submodules=only` option of
> git-push. The feature was added in commit 225e8bf (add option to
> push only submodules).
>
> Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
> ---
>
> Notes:
>     This feature is already in 'next' but was undocumented. Unless somebody reads
>     the release notes, there is no way of knowing about it.

Good eyes; the topic bw/push-submodule-only is already in 'master'.

Looks good to me; Brandon?

Show 35 quoted lines

>
>  Documentation/git-push.txt | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index 8eefabd..1624a35 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -272,7 +272,7 @@ origin +master` to force a push to the `master` branch). See the
>  	standard error stream is not directed to a terminal.
>  
>  --no-recurse-submodules::
> ---recurse-submodules=check|on-demand|no::
> +--recurse-submodules=check|on-demand|only|no::
>  	May be used to make sure all submodule commits used by the
>  	revisions to be pushed are available on a remote-tracking branch.
>  	If 'check' is used Git will verify that all submodule commits that
> @@ -280,11 +280,12 @@ origin +master` to force a push to the `master` branch). See the
>  	remote of the submodule. If any commits are missing the push will
>  	be aborted and exit with non-zero status. If 'on-demand' is used
>  	all submodules that changed in the revisions to be pushed will be
> -	pushed. If on-demand was not able to push all necessary revisions
> -	it will also be aborted and exit with non-zero status. A value of
> -	'no' or using `--no-recurse-submodules` can be used to override the
> -	push.recurseSubmodules configuration variable when no submodule
> -	recursion is required.
> +	pushed. If on-demand was not able to push all necessary revisions it will
> +	also be aborted and exit with non-zero status. If 'only' is used all
> +	submodules will be recursively pushed while the superproject is left
> +	unpushed. A value of 'no' or using `--no-recurse-submodules` can be used
> +	to override the push.recurseSubmodules configuration variable when no
> +	submodule recursion is required.
>  
>  --[no-]verify::
>  	Toggle the pre-push hook (see linkgit:githooks[5]).  The