Re: [PATCH 2/2] completion: add completion for --recurse-submodules=only

From: Stefan Beller <sbeller@google.com>
Date: Feb 2, 2017, 09:30 UTC
Message-ID: <CAGZ79kbN90qNyuQ7HkcTMNY3nMu_cx6i3gEVmXrfOBo5=h94ag@mail.gmail.com>
In-Reply-To: <20170201230753.19462-2-cornelius.weig@tngtech.com>

On Wed, Feb 1, 2017 at 3:07 PM,  <cornelius.weig@tngtech.com> wrote:

Show 10 quoted lines

> From: Cornelius Weig <cornelius.weig@tngtech.com>
>
> Command completion for 'git-push --recurse-submodules' already knows to
> complete some modes. However, the recently added mode 'only' is missing.
>
> Adding 'only' to the recognized modes completes the list of non-trivial
> modes.
>
> Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
> ---

Looks good,

Thanks, Stefan

Show 19 quoted lines

>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index ff7072a..fe3b0f8 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1675,7 +1675,7 @@ _git_pull ()
>         __git_complete_remote_or_refspec
>  }
>
> -__git_push_recurse_submodules="check on-demand"
> +__git_push_recurse_submodules="check on-demand only"
>
>  __git_complete_force_with_lease ()
>  {
> --
> 2.10.2
>