Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 22, 2017, 18:12 UTC
Message-ID: <xmqqinn1kwo6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAHGBnuPL9CUincZkFR758KcZL3-Ra=n_fbsc1EQ=vio2scod5w@mail.gmail.com>

Sebastian Schuberth <sschuberth@gmail.com> writes:

Show 21 quoted lines

> On Wed, Mar 22, 2017 at 4:01 PM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
>
>> Noticed by Sebastian Schuberth.
>
> Thanks for working on the fix.
>
>> +# set up fake editor to replace `pick` by `reword`
>> +cat > reword-editor <<'EOF'
>> +#!/bin/sh
>> +mv "$1" "$1".bup &&
>> +sed 's/^pick/reword/' <"$1".bup >"$1"
>> +EOF
>
> Maybe use
>
> sed -i 's/^pick/reword/' "$1"
>
> here to avoid renaming the input file? Not sure how portable -i for
> sed is, though. Otherwise, maybe remove the file "$1".bup afterwards
> to be clean?

"-i" is GNUism and it is a good idea to avoid it, but cleaning after itself may be worth doing to avoid contaminating the working tree.

Thanks.