git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 23, 2017, 15:52 UTC
Message-ID
<alpine.DEB.2.20.1703231650090.3767@virtualbox>
In-Reply-To
<CAHGBnuOJKopxq4s0e-mw0=siOERDcLXCEF4xzERpq7usbrZa6w@mail.gmail.com>
Hi Sebastian,
On Thu, 23 Mar 2017, Sebastian Schuberth wrote:
Show 9 quoted lines
> On Thu, Mar 23, 2017 at 3:43 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> 
> > I know Sebastian well, and I would hope that he lends his substantial
> > competence to making sure that the changes that affect end users are
> > correct and that I do not introduce another regression.
> 
> If you'd really know me, you would also know that I only say something
> *if* I have to say something.
Okay, then, I sit corrected: I do not know you well.
> I.e. me not making any remarks regarding the C code means I did not find
> any issues.

Sadly, this is indistinguishable from you having not bothered to read the patches to the C code at all.

So an explicit "I have read the patch and found no fault" or even better, a review with some indication that you were thorough would have been a nice gesture.

Ciao, Johannes

Previous: Sebastian SchuberthNext: Junio C Hamano
Message 12 of 27 in “rebase -i (reword): call the commit-msg hook again”
  1. 0/3 rebase -i (reword): call the commit-msg hook againJohannes Schindelin, Mar 22, 2017
  2. 2/3 sequencer: make commit options more extensibleJohannes Schindelin, Mar 22, 2017
  3. Junio C HamanoMar 22, 2017
  4. Johannes SchindelinMar 23, 2017
  5. Junio C HamanoMar 23, 2017
  6. 1/3 t7504: document regression: reword no longer calls commit-msgJohannes Schindelin, Mar 22, 2017
  7. Sebastian SchuberthMar 22, 2017
  8. Johannes SchindelinMar 22, 2017
  9. Junio C HamanoMar 22, 2017
  10. Johannes SchindelinMar 23, 2017
  11. Sebastian SchuberthMar 23, 2017
  12. Johannes SchindelinMar 23, 2017
  13. Junio C HamanoMar 22, 2017
  14. Johannes SchindelinMar 23, 2017
  15. 3/3 sequencer: allow the commit-msg hooks to run during a `reword`Johannes Schindelin, Mar 22, 2017
  16. Junio C HamanoMar 22, 2017
  17. Johannes SchindelinMar 23, 2017
  18. 0/3 rebase -i (reword): call the commit-msg hook againJohannes Schindelin, Mar 23, 2017
  19. 1/3 t7504: document regression: reword no longer calls commit-msgJohannes Schindelin, Mar 23, 2017
  20. 2/3 sequencer: make commit options more extensibleJohannes Schindelin, Mar 23, 2017
  21. Junio C HamanoMar 24, 2017
  22. Johannes SchindelinMar 25, 2017
  23. Junio C HamanoMar 27, 2017
  24. Junio C HamanoMar 27, 2017
  25. Johannes SchindelinMar 29, 2017
  26. 3/3 sequencer: allow the commit-msg hooks to run during a `reword`Johannes Schindelin, Mar 23, 2017
  27. Junio C HamanoMar 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.