git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 4/5] dir_iterator: refactor state machine model

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 18, 2017, 05:13 UTC
Message-ID
<xmqqinm2e1sq.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1492462296-4990-5-git-send-email-bnmvco@gmail.com>
Daniel Ferreira <bnmvco@gmail.com> writes:
> ...
> Signed-off-by: Daniel Ferreira <bnmvco@gmail.com>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>

I had an impression that you took Michael's code snippet and wrote this patch, and if that is the case, the flow of the patch is from Michael to you to me, so these lines are out of order.

Describing which part of this patch owes Michael's contribution in the log message would also not hurt.

Previous: Junio C HamanoNext: Daniel Ferreira
Message 8 of 13 in “[GSoC] remove_subtree(): reimplement using iterators”
  1. 0/5 [GSoC] remove_subtree(): reimplement using iteratorsDaniel Ferreira, Apr 17, 2017
  2. 1/5 dir_iterator: add tests for dir_iterator APIDaniel Ferreira, Apr 17, 2017
  3. Junio C HamanoApr 18, 2017
  4. Junio C HamanoApr 18, 2017
  5. 2/5 remove_subtree(): test removing nested directoriesDaniel Ferreira, Apr 17, 2017
  6. 4/5 dir_iterator: refactor state machine modelDaniel Ferreira, Apr 17, 2017
  7. Junio C HamanoApr 18, 2017
  8. Junio C HamanoApr 18, 2017
  9. 3/5 dir_iterator: add helpers to dir_iterator_advanceDaniel Ferreira, Apr 17, 2017
  10. Junio C HamanoApr 18, 2017
  11. 5/5 remove_subtree(): reimplement using iteratorsDaniel Ferreira, Apr 17, 2017
  12. Junio C HamanoApr 18, 2017
  13. Stefan BellerApr 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.