Re: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 16, 2018, 22:28 UTC
- Message-ID
- <xmqqinc1tp4c.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <007801d38e42$6b6df3b0$4249db10$@nexbridge.com>
"Randall S. Becker" <rsbecker@nexbridge.com> writes:
> I like it. Do you need this resubmitted? Or should I just learn for next > time?
I'll queue the attached for today's iteration. Thanks, both.
-- >8 -- From: "Randall S. Becker" <rsbecker@nexbridge.com> Date: Sun, 14 Jan 2018 13:07:48 -0500 Subject: [PATCH] hashmap.h: remove unused variable
In 'hashmap_enable_item_counting()', item is assigned but never used. This causes a warning on HP NonStop. As the variable is never used, fix this by just removing it.
Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com> Helped-by: Thomas Gummerer <t.gummerer@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- hashmap.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hashmap.h b/hashmap.h index 7cb29a6aed..c41ce392b7 100644 --- a/hashmap.h +++ b/hashmap.h @@ -402,7 +402,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map) */ static inline void hashmap_enable_item_counting(struct hashmap *map) { - void *item; unsigned int n = 0; struct hashmap_iter iter; @@ -410,7 +409,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map) return; hashmap_iter_init(map, &iter); - while ((item = hashmap_iter_next(&iter))) + while (hashmap_iter_next(&iter)) n++; map->do_count_items = 1;
-- 2.16.0-rc2-196-ge713b39cb6