git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] mark_parents_uninteresting(): drop missing object check

From
Junio C Hamano <gitster@pobox.com>
Date
May 13, 2018, 02:23 UTC
Message-ID
<xmqqin7se1jd.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180511180158.GB12543@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
>   2. It "lies" about the commit by setting the parsed flag,
>      even though we didn't load any useful data into the
>      struct. This shouldn't matter for the UNINTERESTING
>      case, but we may later clear our flags and do another
>      traversal in the same process. While pretty unlikely,
>      it's possible that we could then look at the same
>      commit without the UNINTERESTING flag,...

Yeah, if two ranges given to tbdiff to be compared are computed in-core, uninteresting boundary of one range is likely to be interesting on the other range.

Previous: Jeff KingNext: Jeff King
Message 4 of 11 in “a few mark_parents_uninteresting cleanups”
  1. 0/4 a few mark_parents_uninteresting cleanupsJeff King, May 11, 2018
  2. 1/4 mark_tree_contents_uninteresting(): drop missing object checkJeff King, May 11, 2018
  3. 2/4 mark_parents_uninteresting(): drop missing object checkJeff King, May 11, 2018
  4. Junio C HamanoMay 13, 2018
  5. 3/4 mark_parents_uninteresting(): replace list with stackJeff King, May 11, 2018
  6. 4/4 mark_parents_uninteresting(): avoid most allocationJeff King, May 11, 2018
  7. Derrick StoleeMay 14, 2018
  8. Jeff KingMay 14, 2018
  9. Derrick StoleeMay 14, 2018
  10. Jeff KingMay 14, 2018
  11. Derrick StoleeMay 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.