From: Junio C Hamano Date: Sun, 13 May 2018 02:23:50 GMT Subject: Re: [PATCH 2/4] mark_parents_uninteresting(): drop missing object check Message-ID: In-Reply-To: <20180511180158.GB12543@sigill.intra.peff.net> Jeff King writes: > 2. It "lies" about the commit by setting the parsed flag, > even though we didn't load any useful data into the > struct. This shouldn't matter for the UNINTERESTING > case, but we may later clear our flags and do another > traversal in the same process. While pretty unlikely, > it's possible that we could then look at the same > commit without the UNINTERESTING flag,... Yeah, if two ranges given to tbdiff to be compared are computed in-core, uninteresting boundary of one range is likely to be interesting on the other range.